Re: [PATCH] doc: explain why file: URLs and bundles don't mix
- From
Jeff King <peff@peff.net>
- Date
- May 14, 2019, 09:30 UTC
- Message-ID
- <20190514093023.GB11679@sigill.intra.peff.net>
- In-Reply-To
- <20190513165140.vq225fscfvemol7k@x220.qyliss.net>
On Mon, May 13, 2019 at 04:54:55PM +0000, Alyssa Ross wrote:
Show 15 quoted lines
> > I think what is closer to the reaility is that we check if the > > source is a bundle when the local filesystem path is used and try to > > clone from the bundle, before using the local filesystem path as a > > directory we can "clone --local" from. On the other hand, when the > > <scheme>://<path> syntax is used, we do not even bother seeing if > > the named resource is a bundle, or if --local optimization is > > possible (because we do not bother seeing if the named resource is a > > local filesystem entity, either). > > Would the following work better for you? > > When cloning, the former will check to see if the source is a bundle. > If it is, it will clone from the bundle, otherwise it will behave as if > given --local. The latter performs neither of these checks, and > therefore does not support bundles.
FWIW, I like that much better than the original proposal. I think it would also be OK to say something like: ...does not support bundles (but may in the future).
-Peff