git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] builtin/tag: do not omit -v gpg out for --format

From
Santiago Torres Arias <santiago@nyu.edu>
Date
May 9, 2019, 17:36 UTC
Message-ID
<20190509173639.4dghpurz72vhxzzt@LykOS.localdomain>
In-Reply-To
<20190509073644.GA24493@sigill.intra.peff.net>
Show 9 quoted lines
> So we're going to stop setting OMIT_STATUS ever, which makes sense.
> 
> It took me a minute to figure out here that the behavior for VERBOSE is
> not changed, because we _overwrite_ flags, rather than just setting a
> single bit. But that's definitely the right thing to do when there's a
> format (both before and after your patch).
> 
> So this looks good to me. I think we should probably cover it with a
> test in t7004.

Yes, that's something that surprised me originally, as these changes don't make the test suite break in any way...

I'll add a patch to the series with a test for this.

Thanks for the review! -Santiago.

Previous: Jeff KingNext: santiago@nyu.edu
Message 4 of 7 in “tag verification: do not mute gpg output”
  1. 0/2 tag verification: do not mute gpg outputsantiago@nyu.edu, Apr 27, 2019
  2. 1/2 builtin/tag: do not omit -v gpg out for --formatsantiago@nyu.edu, Apr 27, 2019
  3. Jeff KingMay 9, 2019
  4. Santiago Torres AriasMay 9, 2019
  5. 2/2 builtin/verify-tag: do not omit gpg on --formatsantiago@nyu.edu, Apr 27, 2019
  6. Jeff KingMay 9, 2019
  7. Santiago Torres AriasMay 9, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.