git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH] builtin:tag:verify_tag: allow gpg output + pretty

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Apr 23, 2019, 00:00 UTC
Message-ID
<20190423000026.GE6316@genre.crustytoothpaste.net>
In-Reply-To
<20190422232627.3mw3rejbjp5tb7zy@LykOS.localdomain>
On Mon, Apr 22, 2019 at 07:26:29PM -0400, Santiago Torres Arias wrote:
Show 18 quoted lines
> On Mon, Apr 22, 2019 at 11:07:01PM +0000, brian m. carlson wrote:
> > On Mon, Apr 22, 2019 at 12:02:11PM -0400, Jeff King wrote:
> > > On Mon, Apr 22, 2019 at 11:46:56AM -0400, Santiago Torres Arias wrote:
> > > 
> > > > I think that would be great, as we could make it simpler for verifiers
> > > > to parse gpg output.
> > > 
> > > Alternatively, we could make it an option to dump the --status-fd output
> > > to stderr (or to a custom fd). That still leaves the caller with the
> > > responsibility to parse gpg's output, but at least they're parsing the
> > > machine-readable bits and not the regular human-readable stderr.
> > 
> > Don't we already have that for verify-tag and verify-commit? I recall
> > adding "--raw" for that very reason:
> 
> I think this interface only shows you raw gpg output, but not any
> --format= specifiers that you may want. The idea would be to support
> both. Or am I missing something?

My response was mostly in reply to Peff's suggestion that we have an option to dump the --status-fd output, which we have. I think that behavior properly belongs to verify-tag and verify-commit, which are plumbing.

I'm not so sure that it's necessary to have the --status-fd output in git tag -v, which is more for interactive use, although I don't feel strongly about it. I think of --format as a tool I typically want to use on multiple of something, and while it's theoretically possible to distinguish multiple signatures by GnuPG's "NEWSIG", parsing multiple tags' worth of output between standard output and standard error is going to be pretty unpleasant.

As I said, I don't feel strongly about it, so if you want to implement it, feel free.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Previous: Santiago Torres AriasNext: Jeff King
Message 8 of 9 in “builtin:tag:verify_tag: allow gpg output + pretty”
  1. builtin:tag:verify_tag: allow gpg output + prettysantiago@nyu.edu, Apr 12, 2019
  2. Santiago Torres AriasApr 12, 2019
  3. Jeff KingApr 22, 2019
  4. Santiago Torres AriasApr 22, 2019
  5. Jeff KingApr 22, 2019
  6. brian m. carlsonApr 22, 2019
  7. Santiago Torres AriasApr 22, 2019
  8. brian m. carlsonApr 23, 2019
  9. Jeff KingApr 23, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.