Re: [RFC PATCH] builtin:tag:verify_tag: allow gpg output + pretty

From: Santiago Torres Arias <santiago@nyu.edu>
Date: Apr 12, 2019, 20:16 UTC
Message-ID: <20190412201609.hivppg2l37b6pzze@LykOS.localdomain>
In-Reply-To: <20190412201432.11328-1-santiago@nyu.edu>

On Fri, Apr 12, 2019 at 04:14:32PM -0400, santiago@nyu.edu wrote:

Show 8 quoted lines

> From: Santiago Torres <santiago@nyu.edu>
> 
> On the git tag -v code, there is a guard to suppress gpg output if a
> pretty format is provided. The rationale for this is that the gpg output
> *and* the pretty formats together may conflict with each other. However,
> both outputs are directed to different output streams and, as such,
> they can safely coexist. Drop the guard clause and use
> GPG_VERIFY_VERBOSE regardless of the pretty format

I tried digging for the rationale for this, but I couldn't figure it out. I noticed that the output of gpg verification is sent to stderr, while the pretty format goes towards stdout, and they can thus be multiplexed accordingly.

What do you guys think?

Thanks! -Santiago.