Re: [PATCH v2] t5551: mark half-auth no-op fetch test as v0-only
- From
- Jonathan Tan <jonathantanmy@google.com>
- Date
- Apr 8, 2019, 17:01 UTC
- Message-ID
- <20190408170125.124345-1-jonathantanmy@google.com>
- In-Reply-To
- <20190406113113.GA219876@google.com>
Show 18 quoted lines
> > + # NEEDSWORK: When using HTTP(S), protocol v0 supports a "half-auth" > > + # configuration with authentication required only when downloading > > + # objects and not refs, by having the HTTP server only require > > + # authentication for the "git-upload-pack" path and not "info/refs". > > + # This is not possible with protocol v2, since both objects and refs > > + # are obtained from the "git-upload-pack" path. A solution to this is > > + # to teach the server and client to be able to inline ls-refs requests > > + # as an Extra Parameter (see pack-protocol.txt), so that "info/refs" > > + # can serve refs, just like it does in protocol v0. > > + GIT_TEST_PROTOCOL_VERSION=0 git --git-dir=half-auth fetch && > > expect_askpass none > > I suspect it's fine if protocol v2 never supports this. Can we change > the NEEDSWORK comment to say that the protocol v2 spec should document > the lack of support for half-auth? > > With or without such a change, > Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks for your review. Junio brought up a possible workflow that uses this feature [1] and while I don't know if we will ever get around to supporting half-auth in v2, it seems better to me to leave the possibility open.
[1] https://public-inbox.org/git/xmqq36nfsl8t.fsf@gitster-ct.c.googlers.com/