git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH] t5551: delete auth-for-pack-but-not-refs test

From
Jeff King <peff@peff.net>
Date
Mar 21, 2019, 21:48 UTC
Message-ID
<20190321214827.GA22582@sigill.intra.peff.net>
In-Reply-To
<20190321202435.19140-1-jonathantanmy@google.com>
On Thu, Mar 21, 2019 at 01:24:35PM -0700, Jonathan Tan wrote:
Show 11 quoted lines
> > The test you're deleting is basically just verifying that our apache
> > config is indeed "half-auth". Because in v0, the server is never even
> > going to ask for credentials, so no interesting code paths in the client
> > are triggered. So it's not actually testing anything of interest.
> 
> If both of us want to drop this test, that's great :-) but for
> clarification: in addition to verifying that our apache config is
> "half-auth", this test also verifies that in a no-op fetch, we don't hit
> the path that is guarded by an authentication requirement. This seems
> significant to me in light of the link you provided in your prior email
> [1].

Yeah, I suppose it does. I just never really thought of that as a plausible regression to introduce, given the way the v0 protocol works. :)

Although in a sense it is interesting, because it did reveal something about v2 that we hadn't considered. I don't think it's worth addressing (especially now), but had we been doing cross-protocol tests sooner, we might have looked at it more in the design phase.

So I would also be OK with just marking it as as v0-only test.
-Peff
Previous: Jonathan TanNext: Jonathan Tan
Message 5 of 12 in “t5551: delete auth-for-pack-but-not-refs test”
  1. t5551: delete auth-for-pack-but-not-refs testJonathan Tan, Mar 21, 2019
  2. Jeff KingMar 21, 2019
  3. Jeff KingMar 21, 2019
  4. Jonathan TanMar 21, 2019
  5. Jeff KingMar 21, 2019
  6. Jonathan TanMar 21, 2019
  7. Junio C HamanoMar 22, 2019
  8. Jonathan TanMar 22, 2019
  9. t5551: mark half-auth no-op fetch test as v0-onlyJonathan Tan, Mar 22, 2019
  10. Jeff KingMar 23, 2019
  11. Jonathan NiederApr 6, 2019
  12. Jonathan TanApr 8, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.