git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 03/11] promisor-remote: implement promisor_remote_get_direct()

From
Christian Couder <christian.couder@gmail.com>
Date
Apr 1, 2019, 16:40 UTC
Message-ID
<20190401164045.17328-4-chriscool@tuxfamily.org>
In-Reply-To
<20190401164045.17328-1-chriscool@tuxfamily.org>
From: Christian Couder <christian.couder@gmail.com>

This is implemented for now by calling fetch_objects(). It fetches from all the promisor remotes.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 promisor-remote.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++
 promisor-remote.h |  1 +
 2 files changed, 65 insertions(+)
diff --git a/promisor-remote.c b/promisor-remote.c
index 0c768210ee..a3d601e45a 100644
--- a/promisor-remote.c
+++ b/promisor-remote.c
@@ -1,6 +1,8 @@
 #include "cache.h"
+#include "object-store.h"
 #include "promisor-remote.h"
 #include "config.h"
+#include "fetch-object.h"
 
 static struct promisor_remote *promisors;
 static struct promisor_remote **promisors_tail = &promisors;
@@ -90,3 +92,65 @@ int has_promisor_remote(void)
 {
 	return !!promisor_remote_find(NULL);
 }
+
+static int remove_fetched_oids(struct object_id **oids, int oid_nr, int to_free)
+{
+	int i, missing_nr = 0;
+	int *missing = xcalloc(oid_nr, sizeof(*missing));
+	struct object_id *old_oids = *oids;
+	struct object_id *new_oids;
+	int old_fetch_if_missing = fetch_if_missing;
+
+	fetch_if_missing = 0;
+
+	for (i = 0; i < oid_nr; i++)
+		if (oid_object_info_extended(the_repository, &old_oids[i], NULL, 0)) {
+			missing[i] = 1;
+			missing_nr++;
+		}
+
+	fetch_if_missing = old_fetch_if_missing;
+
+	if (missing_nr) {
+		int j = 0;
+		new_oids = xcalloc(missing_nr, sizeof(*new_oids));
+		for (i = 0; i < oid_nr; i++)
+			if (missing[i])
+				oidcpy(&new_oids[j++], &old_oids[i]);
+		*oids = new_oids;
+		if (to_free)
+			free(old_oids);
+	}
+
+	return missing_nr;
+}
+
+int promisor_remote_get_direct(const struct object_id *oids, int oid_nr)
+{
+	struct promisor_remote *r;
+	struct object_id *missing_oids = (struct object_id *)oids;
+	int missing_nr = oid_nr;
+	int to_free = 0;
+	int res = -1;
+
+	promisor_remote_init();
+
+	for (r = promisors; r; r = r->next) {
+		if (fetch_objects(r->name, missing_oids, missing_nr) < 0) {
+			if (missing_nr == 1)
+				continue;
+			missing_nr = remove_fetched_oids(&missing_oids, missing_nr, to_free);
+			if (missing_nr) {
+				to_free = 1;
+				continue;
+			}
+		}
+		res = 0;
+		break;
+	}
+
+	if (to_free)
+		free(missing_oids);
+
+	return res;
+}
diff --git a/promisor-remote.h b/promisor-remote.h
index 01dcdf4dc7..30c0b3dcb6 100644
--- a/promisor-remote.h
+++ b/promisor-remote.h
@@ -12,5 +12,6 @@ struct promisor_remote {
 
 extern struct promisor_remote *promisor_remote_find(const char *remote_name);
 extern int has_promisor_remote(void);
+extern int promisor_remote_get_direct(const struct object_id *oids, int oid_nr);
 
 #endif /* PROMISOR_REMOTE_H */
-- 
2.21.0.203.gd44fa53258
Previous: Christian CouderNext: Christian Couder
Message 6 of 18 in “Many promisor remotes”
  1. 00/11 Many promisor remotesChristian Couder, Apr 1, 2019
  2. 01/11 fetch-object: make functions return an error codeChristian Couder, Apr 1, 2019
  3. 02/11 Add initial support for many promisor remotesChristian Couder, Apr 1, 2019
  4. SZEDER GáborApr 3, 2019
  5. Christian CouderApr 4, 2019
  6. 03/11 promisor-remote: implement promisor_remote_get_direct()Christian Couder, Apr 1, 2019
  7. 04/11 promisor-remote: add promisor_remote_reinit()Christian Couder, Apr 1, 2019
  8. 05/11 promisor-remote: use repository_format_partial_cloneChristian Couder, Apr 1, 2019
  9. 06/11 Use promisor_remote_get_direct() and has_promisor_remote()Christian Couder, Apr 1, 2019
  10. 07/11 promisor-remote: parse remote.*.partialclonefilterChristian Couder, Apr 1, 2019
  11. 08/11 builtin/fetch: remove unique promisor remote limitationChristian Couder, Apr 1, 2019
  12. 09/11 t0410: test fetching from many promisor remotesChristian Couder, Apr 1, 2019
  13. SZEDER GáborApr 5, 2019
  14. 10/11 partial-clone: add multiple remotes in the docChristian Couder, Apr 1, 2019
  15. 11/11 remote: add promisor and partial clone config to the docChristian Couder, Apr 1, 2019
  16. Junio C HamanoApr 4, 2019
  17. Christian CouderApr 4, 2019
  18. Johannes SchindelinApr 5, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.