git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/4] t6050: use test_line_count instead of wc -l

From
Christian Couder <christian.couder@gmail.com>
Date
Mar 31, 2019, 13:46 UTC
Message-ID
<20190331134659.28808-2-chriscool@tuxfamily.org>
In-Reply-To
<20190331134659.28808-1-chriscool@tuxfamily.org>
This modernizes a test and makes it more portable.
Reviewed-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 t/t6050-replace.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t6050-replace.sh b/t/t6050-replace.sh
index d638119750..41b177936e 100755
--- a/t/t6050-replace.sh
+++ b/t/t6050-replace.sh
@@ -393,9 +393,11 @@ test_expect_success 'replace ref cleanup' '
 '
 
 test_expect_success '--graft with and without already replaced object' '
-	test $(git log --oneline | wc -l) = 7 &&
+	git log --oneline >log &&
+	test_line_count = 7 log &&
 	git replace --graft $HASH5 &&
-	test $(git log --oneline | wc -l) = 3 &&
+	git log --oneline >log &&
+	test_line_count = 3 log &&
 	commit_has_parents $HASH5 &&
 	test_must_fail git replace --graft $HASH5 $HASH4 $HASH3 &&
 	git replace --force -g $HASH5 $HASH4 $HASH3 &&
-- 
2.21.0.69.g2d86a08d09
Previous: Christian CouderNext: Christian Couder
Message 2 of 6 in “fix `git replace --graft` tag related issues”
  1. 0/4 fix `git replace --graft` tag related issuesChristian Couder, Mar 31, 2019
  2. 1/4 t6050: use test_line_count instead of wc -lChristian Couder, Mar 31, 2019
  3. 3/4 replace: fix --graft when passing a tag as parentChristian Couder, Mar 31, 2019
  4. 2/4 t6050: redirect expected error output to a fileChristian Couder, Mar 31, 2019
  5. 4/4 replace: fix --graft when passing a tag firstChristian Couder, Mar 31, 2019
  6. Junio C HamanoApr 1, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.