git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/4] fix `git replace --graft` tag related issues

From
Christian Couder <christian.couder@gmail.com>
Date
Mar 31, 2019, 13:46 UTC
Message-ID
<20190331134659.28808-1-chriscool@tuxfamily.org>

This is version 2 of a small patch series to fix tag related issues in `git replace --graft` that Andreas Schwab reported in:

https://public-inbox.org/git/mvmd0mcsjkf.fsf@suse.de/
The first version of this patch series was:
https://public-inbox.org/git/20190328171722.9753-1-chriscool@tuxfamily.org/
Changes compared to the previous version are the following:
  - patch 4/4 has been added to fix issues when a tag is passed first
  - in patch 2/4 the error message is redirected to a file instead of
    /dev/null as suggested by Ævar after a comment by Eric
  - title of patch 3/4 has been extended with "as parent" to make it
    different from title of patch 4/4

I saw that t6050 has existing 4-space-instead-of-tabs issues, but it can perhaps be dealt with if some bigger changes are made to this test script.

Thanks Taylor for the review, and Eric and Ævar for the comments/suggestions!

Christian Couder (4):
  t6050: use test_line_count instead of wc -l
  t6050: redirect expected error output to a file
  replace: fix --graft when passing a tag as parent
  replace: fix --graft when passing a tag first
 builtin/replace.c  | 20 +++++++++++++-------
 t/t6050-replace.sh | 31 ++++++++++++++++++++++++++++---
 2 files changed, 41 insertions(+), 10 deletions(-)
-- 
2.21.0.69.g2d86a08d09
Next: Christian Couder
Message 1 of 6 in “fix `git replace --graft` tag related issues”
  1. 0/4 fix `git replace --graft` tag related issuesChristian Couder, Mar 31, 2019
  2. 1/4 t6050: use test_line_count instead of wc -lChristian Couder, Mar 31, 2019
  3. 3/4 replace: fix --graft when passing a tag as parentChristian Couder, Mar 31, 2019
  4. 2/4 t6050: redirect expected error output to a fileChristian Couder, Mar 31, 2019
  5. 4/4 replace: fix --graft when passing a tag firstChristian Couder, Mar 31, 2019
  6. Junio C HamanoApr 1, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.