[PATCH 12/13] pretty: drop unused strbuf from parse_padding_placeholder()
- From
Jeff King <peff@peff.net>
- Date
- Mar 20, 2019, 08:16 UTC
- Message-ID
- <20190320081642.GL10403@sigill.intra.peff.net>
- In-Reply-To
- <20190320081258.GA5621@sigill.intra.peff.net>
Unlike other parts of the --pretty user-format expansion, this function is not actually writing to the output, but instead just storing the padding values into a context struct. We don't need to be passed a strbuf at all.
Signed-off-by: Jeff King <peff@peff.net> --- pretty.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/pretty.c b/pretty.c index f925a014f9..ced0485257 100644 --- a/pretty.c +++ b/pretty.c @@ -988,8 +988,7 @@ static size_t parse_color(struct strbuf *sb, /* in UTF-8 */ return rest - placeholder; } -static size_t parse_padding_placeholder(struct strbuf *sb, - const char *placeholder, +static size_t parse_padding_placeholder(const char *placeholder, struct format_commit_context *c) { const char *ch = placeholder; @@ -1194,7 +1193,7 @@ static size_t format_commit_one(struct strbuf *sb, /* in UTF-8 */ case '<': case '>': - return parse_padding_placeholder(sb, placeholder, c); + return parse_padding_placeholder(placeholder, c); } /* these depend on the commit */
-- 2.21.0.701.g4401309e11