[PATCH 10/13] parse-options: drop unused ctx parameter from show_gitcomp()
- From
Jeff King <peff@peff.net>
- Date
- Mar 20, 2019, 08:16 UTC
- Message-ID
- <20190320081627.GJ10403@sigill.intra.peff.net>
- In-Reply-To
- <20190320081258.GA5621@sigill.intra.peff.net>
The completion display doesn't actually care about where we are in the parsing. It's generated completely from the set of available options. So we don't need to see the parse-options context struct at all.
Signed-off-by: Jeff King <peff@peff.net> --- parse-options.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/parse-options.c b/parse-options.c index cec74522e5..ade83a7b20 100644 --- a/parse-options.c +++ b/parse-options.c @@ -523,8 +523,7 @@ static void show_negated_gitcomp(const struct option *opts, int nr_noopts) } } -static int show_gitcomp(struct parse_opt_ctx_t *ctx, - const struct option *opts) +static int show_gitcomp(const struct option *opts) { const struct option *original_opts = opts; int nr_noopts = 0; @@ -603,7 +602,7 @@ int parse_options_step(struct parse_opt_ctx_t *ctx, /* lone --git-completion-helper is asked by git-completion.bash */ if (ctx->total == 1 && !strcmp(arg + 1, "-git-completion-helper")) - return show_gitcomp(ctx, options); + return show_gitcomp(options); if (arg[1] != '-') { ctx->opt = arg + 1;
-- 2.21.0.701.g4401309e11