Re: [PATCH 1/2] fetch: avoid calling write_or_die()

From: Jeff King <peff@peff.net>
Date: Mar 5, 2019, 04:11 UTC
Message-ID: <20190305041158.GB19800@sigill.intra.peff.net>
In-Reply-To: <CACsJy8BWp9+SDwcXv_a6aFN=YSoQN3E7sOGDRm5a6Pi7QhzexQ@mail.gmail.com>

On Mon, Mar 04, 2019 at 08:42:40PM +0700, Duy Nguyen wrote:

Show 7 quoted lines

> > -       } else
> > -               write_or_die(fd, buf->buf, buf->len);
> > +       } else {
> > +               if (write_in_full(fd, buf->buf, buf->len) < 0)
> > +                       die_errno("unable to write to remote");
> 
> maybe _() these strings.

Good thinking. I just sent an update in another part of the thread.

-Peff