Re: t5570-git-daemon fails with SIGPIPE on OSX
- From
Jeff King <peff@peff.net>
- Date
- Aug 14, 2018, 22:37 UTC
- Message-ID
- <20180814223737.GA9241@sigill.intra.peff.net>
- In-Reply-To
- <20180814223246.GA2379@sigill.intra.peff.net>
On Tue, Aug 14, 2018 at 06:32:47PM -0400, Jeff King wrote:
> I suspect the (largely untested) patch below would make your test > problems go away. Or instead, we could simply add sigpipe=ok to the > test_must_fail invocation, but I agree with you that the current > behavior on OS X is not ideal (the user sees no error message).
Whoops, that patch of course misses adding "sigchain_push(SIGPIPE, SIG_IGN)" during the fetch-pack operation. I'll leave that as an exercise to the reader. ;)
-Peff