Re: [WIP 7/7] upload-pack: send part of packfile response as uri

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Feb 26, 2019, 01:53 UTC
Message-ID: <20190226015329.GE16965@google.com>
In-Reply-To: <CAP8UFD2RBU+f4=pB4CZHPHVO3DKXdGXVen=x3a8GvQHhGBG3aA@mail.gmail.com>

Hi,

Christian Couder wrote:

> On Sun, Feb 24, 2019 at 12:39 AM Jonathan Tan <jonathantanmy@google.com> wrote:

Show 9 quoted lines

>> Teach upload-pack to send part of its packfile response as URIs.
>>
>> An administrator may configure a repository with one or more
>> "uploadpack.blobpackfileuri" lines, each line containing an OID and a
>> URI. A client may configure fetch.uriprotocols to be a comma-separated
>> list of protocols that it is willing to use to fetch additional
>> packfiles - this list will be sent to the server.
>
> So only packfiles will be fetched by the client using those protocols.

Yes.

Show 9 quoted lines

>> Whenever an object
>> with one of those OIDs would appear in the packfile transmitted by
>> upload-pack, the server may exclude that object, and instead send the
>> URI.
>
> Ok, so each URI sent in the packfile corresponds to exactly one
> object. And when the client fetches one such URI it gets a packfile
> that contains only the corresponding object. Or is there something I
> misunderstood?

I think it's worth separating the protocol and the server implementation:

The protocol allows arbitrary packfiles --- they do not have to be single-object packfiles.

This patch for a server implementation only uses it to serve single-object packfiles.

Thanks, Jonathan