Re: [Suggestion] Add Skip for t9020

From: Jeff King <peff@peff.net>
Date: Feb 22, 2019, 15:30 UTC
Message-ID: <20190222153054.GD21524@sigill.intra.peff.net>
In-Reply-To: <20190221205837.GX16125@zaya.teonanacatl.net>

On Thu, Feb 21, 2019 at 03:58:37PM -0500, Todd Zullinger wrote:

Show 13 quoted lines

> > While this is a bit of a hack, it might be useful for skipping t9020 in
> > environments where the svn.remote package is not installed. I can make this
> > into a patch if this style is reasonable - guessing probably not and that
> > the REMOTE_SVN test should go elsewhere if it is called that.
> 
> Jeff King sent an RFC patch which would remove this test and
> the rest of the vcs-svn experiment in August[1].  Jonathan
> Nieder replied as one user who would rather see it moved to
> contrib/, so it was held off.
> 
> Whether that has any impact on adding a way to skip all the
> tests here, I don't know.  Maybe it's a gentle nudge in
> favor of moving them to contrib?

I still hoped we could ditch them completely. :) As part of my -Wunused-parameter patches, I found that was an easy way to get rid of some warnings. But I'd be OK if they were in contrib/, too.

-Peff