Re: [Suggestion] Add Skip for t9020

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Feb 22, 2019, 00:46 UTC
Message-ID: <20190222004659.GA167507@google.com>
In-Reply-To: <004b01d4ca23$faebcad0$f0c36070$@nexbridge.com>

Hi,

Randall S. Becker wrote:

Show 23 quoted lines

> While this is a bit of a hack, it might be useful for skipping t9020 in
> environments where the svn.remote package is not installed. I can make this
> into a patch if this style is reasonable - guessing probably not and that
> the REMOTE_SVN test should go elsewhere if it is called that.
>
> diff --git a/t/t9020-remote-svn.sh b/t/t9020-remote-svn.sh
> index 6fca08e5e3..31edf99371 100755
> --- a/t/t9020-remote-svn.sh
> +++ b/t/t9020-remote-svn.sh
> @@ -12,6 +12,12 @@ then
>         test_done
>  fi
>
> +python -c "import svn.remote" 2>/dev/null >/dev/null
> +if [ $? -eq 0 ]; then
> +       test_set_prereq REMOTE_SVN
> +fi
> +if ! test_have_prereq REMOTE_SVN
> +then
> +       skip_all='skipping remote-svn tests, python svn.remote not
> available'
> +       test_done
> +fi

Interesting. Where do we use the svn.remote package? I did a quick grep and didn't find any instances.

Do you have output from running "./t9020-remote-svn.sh -v -i"?

Thanks, Jonathan