[RFC PATCH 3/5] fast-import: check most prominent commands first
- From
Elijah Newren <newren@gmail.com>
- Date
- Feb 20, 2019, 22:58 UTC
- Message-ID
- <20190220225846.10658-4-newren@gmail.com>
- In-Reply-To
- <20190220225846.10658-1-newren@gmail.com>
This is not a very important change, and one that I expect to have no performance impact whatsoever, but reading the code bothered me. The parsing of command types in cmd_main() mostly runs in order of most common to least common commands; sure, it's hard to say for sure what the most common are without some type of study, but it seems fairly clear to mark the original four ("blob", "commit", "tag", "reset") as the most prominent. Indeed, the parsing for most other commands were added to later in the list. However, when "ls" was added, it was stuck near the top of the list, with no rationale for that particular location. Move it down to later to appease my Tourette's-like internal twitching that its former location was causing.
Signed-off-by: Elijah Newren <newren@gmail.com> --- fast-import.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fast-import.c b/fast-import.c index b7ba755c2b..3114ce17f1 100644 --- a/fast-import.c +++ b/fast-import.c @@ -3303,14 +3303,14 @@ int cmd_main(int argc, const char **argv) const char *v; if (!strcmp("blob", command_buf.buf)) parse_new_blob(); - else if (skip_prefix(command_buf.buf, "ls ", &v)) - parse_ls(v, NULL); else if (skip_prefix(command_buf.buf, "commit ", &v)) parse_new_commit(v); else if (skip_prefix(command_buf.buf, "tag ", &v)) parse_new_tag(v); else if (skip_prefix(command_buf.buf, "reset ", &v)) parse_reset_branch(v); + else if (skip_prefix(command_buf.buf, "ls ", &v)) + parse_ls(v, NULL); else if (!strcmp("checkpoint", command_buf.buf)) parse_checkpoint(); else if (!strcmp("done", command_buf.buf))
-- 2.21.0.rc2.5.g8f70af2367