git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 2/5] git-fast-import.txt: fix wording about where ls command can appear

From
Elijah Newren <newren@gmail.com>
Date
Feb 20, 2019, 22:58 UTC
Message-ID
<20190220225846.10658-3-newren@gmail.com>
In-Reply-To
<20190220225846.10658-1-newren@gmail.com>

The docs claimed `ls` commands could appear almost anywhere, but the code told a different story. Modify the docs to match the code.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 Documentation/git-fast-import.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt
index 339b6e7e98..f7e2d330b1 100644
--- a/Documentation/git-fast-import.txt
+++ b/Documentation/git-fast-import.txt
@@ -1016,8 +1016,8 @@ printing a blob from the active commit (with `cat-blob`) or copying a
 blob or tree from a previous commit for use in the current one (with
 `filemodify`).
 
-The `ls` command can be used anywhere in the stream that comments are
-accepted, including the middle of a commit.
+The `ls` command can also be used where a `filemodify` directive can
+appear, allowing it to be used in the middle of a commit.
 
 Reading from the active commit::
 	This form can only be used in the middle of a `commit`.
-- 
2.21.0.rc2.5.g8f70af2367
Previous: Elijah NewrenNext: Elijah Newren
Message 3 of 15 in “Fix some fast-import parsing issues”
  1. 0/5 Fix some fast-import parsing issuesElijah Newren, Feb 20, 2019
  2. 5/5 fast-import: fix erroneous handling of get-mark with empty orphan commitsElijah Newren, Feb 20, 2019
  3. 2/5 git-fast-import.txt: fix wording about where ls command can appearElijah Newren, Feb 20, 2019
  4. 3/5 fast-import: check most prominent commands firstElijah Newren, Feb 20, 2019
  5. 4/5 fast-import: only allow cat-blob requests where it makes senseElijah Newren, Feb 20, 2019
  6. 1/5 t9300: demonstrate bug with get-mark and empty orphan commitsElijah Newren, Feb 20, 2019
  7. Elijah NewrenMar 8, 2019
  8. Junio C HamanoApr 1, 2019
  9. Elijah NewrenApr 1, 2019
  10. 0/5 Fix some fast-import parsing issuesElijah Newren, Apr 1, 2019
  11. 1/5 t9300: demonstrate bug with get-mark and empty orphan commitsElijah Newren, Apr 1, 2019
  12. 5/5 fast-import: fix erroneous handling of get-mark with empty orphan commitsElijah Newren, Apr 1, 2019
  13. 3/5 fast-import: check most prominent commands firstElijah Newren, Apr 1, 2019
  14. 4/5 fast-import: only allow cat-blob requests where it makes senseElijah Newren, Apr 1, 2019
  15. 2/5 git-fast-import.txt: fix wording about where ls command can appearElijah Newren, Apr 1, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.