git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2 1/2] git-p4: add failing test for shelved CL update involving move

From
MAMazo, Andrey <amazo@checkvideo.com>
Date
Jan 16, 2019, 23:40 UTC
Message-ID
<20190116234001.15234-1-amazo@checkvideo.com>
In-Reply-To
<20190114235524.3947-2-luke@diamand.org>
Show 12 quoted lines
> 
> Updating a shelved P4 changelist where one or more files have
> been moved does not work. Add a test for this.
> 
> The problem is that P4 requires a complete list of the files being
> changed, and move/rename only includes the _source_ in the case of
> updating a shelved changelist. This results in errors from Perforce
> such as:
> 
>   //depot/src - needs tofile //depot/dst
>   Submit aborted -- fix problems then use 'p4 submit -c 1234'
>

Shouldn't a similar test case and a fix be added for the "copy" case too? The code looks very similar to the "move" case, so will probably fail in a similar way, right?

For the "move" test case and the fix, please, feel free to add my
Acked-by: Andrey Mazo <amazo@checkvideo.com>
(if it's of any use)

Thank you, Andrey

Previous: Luke Diamand
Message 4 of 4 in “[PATCHv2 0/2] git-p4: handle moved files when updating a P4 shelve”
  1. Luke DiamandJan 14, 2019
  2. 1/2 git-p4: add failing test for shelved CL update involving moveLuke Diamand, Jan 14, 2019
  3. 2/2 git-p4: handle update of moved files when updating a shelveLuke Diamand, Jan 14, 2019
  4. Mazo, AndreyJan 16, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.