From: Mazo, Andrey <amazo@checkvideo.com>
Date: Wed, 16 Jan 2019 23:40:23 GMT
Subject: Re: [PATCHv2 1/2] git-p4: add failing test for shelved CL update involving move
Message-ID: <20190116234001.15234-1-amazo@checkvideo.com>
In-Reply-To: <20190114235524.3947-2-luke@diamand.org>

> 
> Updating a shelved P4 changelist where one or more files have
> been moved does not work. Add a test for this.
> 
> The problem is that P4 requires a complete list of the files being
> changed, and move/rename only includes the _source_ in the case of
> updating a shelved changelist. This results in errors from Perforce
> such as:
> 
>   //depot/src - needs tofile //depot/dst
>   Submit aborted -- fix problems then use 'p4 submit -c 1234'
> 

Shouldn't a similar test case and a fix be added for the "copy" case too?
The code looks very similar to the "move" case, so will probably fail in a similar way, right?

For the "move" test case and the fix, please, feel free to add my
Acked-by: Andrey Mazo <amazo@checkvideo.com>
(if it's of any use)

Thank you,
Andrey