Re: [PATCH] .mailmap: record canonical email address for Sven Strickroth

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Nov 20, 2018, 21:58 UTC
Message-ID: <20181120215803.GA149929@google.com>
In-Reply-To: <15b7df69-25d8-c168-dd43-a43b7fee23d2@cs-ware.de>

Hi,

Sven Strickroth wrote:

Show 6 quoted lines

> Subject: .mailmap: record canonical email address for Sven Strickroth
>
> Signed-off-by: Sven Strickroth <email@cs-ware.de>
> ---
>  .mailmap | 2 ++
>  1 file changed, 2 insertions(+)

Thanks for taking care of it.

[...]

Show 7 quoted lines

> --- a/.mailmap
> +++ b/.mailmap
> @@ -235,6 +235,8 @@ Steven Grimm <koreth@midwinter.com> <sgrimm@sgrimm-mbp.local>
>  Steven Grimm <koreth@midwinter.com> koreth@midwinter.com
>  Steven Walter <stevenrwalter@gmail.com> <swalter@lexmark.com>
>  Steven Walter <stevenrwalter@gmail.com> <swalter@lpdev.prtdev.lexmark.com>
> +Sven Strickroth <email@cs-ware.de> <sven@cs-ware.de>

Is the above line needed? It's not clear to me from the commit message what it does.

> +Sven Strickroth <email@cs-ware.de> <sven.strickroth@tu-clausthal.de>

This line looks good.

>  Sven Verdoolaege <skimo@kotnet.org> <Sven.Verdoolaege@cs.kuleuven.ac.be>
>  Sven Verdoolaege <skimo@kotnet.org> <skimo@liacs.nl>
>  SZEDER G??bor <szeder.dev@gmail.com> <szeder@ira.uka.de>

This line does not seem to have survived mailing. Fortunately it's a context line, but thought I should mention it for the future.

Thanks and hope that helps, Jonathan