threads / patch / 49868

patch.mailmap: record canonical email address for Sven Strickroth

Subject: [PATCH] .mailmap: record canonical email address for Sven Strickroth

## tl;dr

3 messages between Nov 20, 2018 and Nov 21, 2018. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Sven Strickroth· Nov 20, 2018, 19:40 UTC · lore

Signed-off-by: Sven Strickroth <email@cs-ware.de>
---
 .mailmap | 2 ++
 1 file changed, 2 insertions(+)

Show changes to .mailmap +2 −0

diff --git a/.mailmap b/.mailmap
index f165222a78..a30f409f39 100644
--- a/.mailmap
+++ b/.mailmap
@@ -235,6 +235,8 @@ Steven Grimm <koreth@midwinter.com> <sgrimm@sgrimm-mbp.local>
 Steven Grimm <koreth@midwinter.com> koreth@midwinter.com
 Steven Walter <stevenrwalter@gmail.com> <swalter@lexmark.com>
 Steven Walter <stevenrwalter@gmail.com> <swalter@lpdev.prtdev.lexmark.com>
+Sven Strickroth <email@cs-ware.de> <sven@cs-ware.de>
+Sven Strickroth <email@cs-ware.de> <sven.strickroth@tu-clausthal.de>
 Sven Verdoolaege <skimo@kotnet.org> <Sven.Verdoolaege@cs.kuleuven.ac.be>
 Sven Verdoolaege <skimo@kotnet.org> <skimo@liacs.nl>
 SZEDER Gábor <szeder.dev@gmail.com> <szeder@ira.uka.de>

-- 
2.19.1.windows.1

Jonathan Nieder· Nov 20, 2018, 21:58 UTC · re: Sven Strickroth · lore

Re: [PATCH] .mailmap: record canonical email address for Sven Strickroth

Hi,

Sven Strickroth wrote:

Show 6 quoted lines

> Subject: .mailmap: record canonical email address for Sven Strickroth
>
> Signed-off-by: Sven Strickroth <email@cs-ware.de>
> ---
>  .mailmap | 2 ++
>  1 file changed, 2 insertions(+)

Thanks for taking care of it.

[...]

Show 7 quoted lines

> --- a/.mailmap
> +++ b/.mailmap
> @@ -235,6 +235,8 @@ Steven Grimm <koreth@midwinter.com> <sgrimm@sgrimm-mbp.local>
>  Steven Grimm <koreth@midwinter.com> koreth@midwinter.com
>  Steven Walter <stevenrwalter@gmail.com> <swalter@lexmark.com>
>  Steven Walter <stevenrwalter@gmail.com> <swalter@lpdev.prtdev.lexmark.com>
> +Sven Strickroth <email@cs-ware.de> <sven@cs-ware.de>

Is the above line needed? It's not clear to me from the commit message what it does.

> +Sven Strickroth <email@cs-ware.de> <sven.strickroth@tu-clausthal.de>

This line looks good.

>  Sven Verdoolaege <skimo@kotnet.org> <Sven.Verdoolaege@cs.kuleuven.ac.be>
>  Sven Verdoolaege <skimo@kotnet.org> <skimo@liacs.nl>
>  SZEDER G??bor <szeder.dev@gmail.com> <szeder@ira.uka.de>

This line does not seem to have survived mailing. Fortunately it's a context line, but thought I should mention it for the future.

Thanks and hope that helps, Jonathan

Junio C Hamano· Nov 21, 2018, 00:00 UTC · re: Jonathan Nieder · lore

Re: [PATCH] .mailmap: record canonical email address for Sven Strickroth

Jonathan Nieder <jrnieder@gmail.com> writes:

>> +Sven Strickroth <email@cs-ware.de> <sven@cs-ware.de>
>
> Is the above line needed?  It's not clear to me from the commit message
> what it does.

Stare at it once again and you'll see ;-) FWIW I needed to do that myself before you had the same issue.

Sven is trying to hide real-name name and have a bland token that would leave the least amount of impression to the recipients there instead, i.e. "email@add.re.ss".