git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: grep issues

From
Torsten Bögershausen <tboegi@web.de>
Date
Nov 20, 2018, 05:21 UTC
Message-ID
<20181120052154.GB16814@tor.lan>
In-Reply-To
<CAGHpTB+fQccqR8SF2_dS3itboKd79238KCFRe4-3PZz6bpr3iQ@mail.gmail.com>
On Sun, Nov 11, 2018 at 03:17:50PM +0200, Orgad Shaneh wrote:
Show 22 quoted lines
> Hi,
> 
> I found 2 bugs in grep, using Git for Windows 2.19.1 (but noticed
> these several versions ago):
> 
> 1. git grep --recursive on a worktree (without rev) always matches
> against the submodule's HEAD, not its worktree, as it should.
> 2. When core.autocrlf (or eol=crlf) is used, and a file in the
> worktree has CRLF, git grep fails to match $ against EOL.
> 
> For example:
> git init
> echo 'file eol=crlf' > .gitattributes
> echo ABCD > file
> git add file
> git commit -m 'CRLF'
> rm file
> git checkout -f file
> git grep 'D$' file # Nothing
> git grep 'D$' HEAD -- file # Found!
> 
> - Orgad

I can confirm the "2. When core.autocrlf" bug, or should we call it a non-implemented feature. It seems as if a convert_to_git() is needed in grep.c, but I haven't found the time to dig deeper. Does anybody wants to work on this ?

Previous: Orgad Shaneh
Message 2 of 2 in “grep issues”
  1. Orgad ShanehNov 11, 2018
  2. Torsten BögershausenNov 20, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.