grep issues

Orgad Shaneh· Nov 11, 2018, 13:17 UTC · lore

Hi,

I found 2 bugs in grep, using Git for Windows 2.19.1 (but noticed these several versions ago):

1. git grep --recursive on a worktree (without rev) always matches
against the submodule's HEAD, not its worktree, as it should.
2. When core.autocrlf (or eol=crlf) is used, and a file in the
worktree has CRLF, git grep fails to match $ against EOL.

For example: git init echo 'file eol=crlf' > .gitattributes echo ABCD > file git add file git commit -m 'CRLF' rm file git checkout -f file git grep 'D$' file # Nothing git grep 'D$' HEAD -- file # Found!

- Orgad

Torsten Bögershausen· Nov 20, 2018, 05:21 UTC · re: Orgad Shaneh · lore

Re: grep issues

On Sun, Nov 11, 2018 at 03:17:50PM +0200, Orgad Shaneh wrote:

Show 22 quoted lines

> Hi,
> 
> I found 2 bugs in grep, using Git for Windows 2.19.1 (but noticed
> these several versions ago):
> 
> 1. git grep --recursive on a worktree (without rev) always matches
> against the submodule's HEAD, not its worktree, as it should.
> 2. When core.autocrlf (or eol=crlf) is used, and a file in the
> worktree has CRLF, git grep fails to match $ against EOL.
> 
> For example:
> git init
> echo 'file eol=crlf' > .gitattributes
> echo ABCD > file
> git add file
> git commit -m 'CRLF'
> rm file
> git checkout -f file
> git grep 'D$' file # Nothing
> git grep 'D$' HEAD -- file # Found!
> 
> - Orgad

I can confirm the "2. When core.autocrlf" bug, or should we call it a non-implemented feature. It seems as if a convert_to_git() is needed in grep.c, but I haven't found the time to dig deeper. Does anybody wants to work on this ?