Re: [PATCH v3 00/11] fast export and import fixes and features
- From
Jeff King <peff@peff.net>
- Date
- Nov 16, 2018, 08:50 UTC
- Message-ID
- <20181116085016.GA20828@sigill.intra.peff.net>
- In-Reply-To
- <20181116075956.27047-1-newren@gmail.com>
On Thu, Nov 15, 2018 at 11:59:45PM -0800, Elijah Newren wrote:
Show 11 quoted lines
> This is a series of small fixes and features for fast-export and > fast-import, mostly on the fast-export side. > > Changes since v2 (full range-diff below): > * Dropped the final patch; going to try to use Peff's suggestion of > rev-list and diff-tree to get what I need instead > * Inserted a new patch at the beginning to convert pre-existing sha1 > stuff to oid (rename sha1_to_hex() -> oid_to_hex(), rename > anonymize_sha1() to anonymize_oid(), etc.) > * Modified other patches in the series to add calls to oid_to_hex() rather > than sha1_to_hex()
Thanks, these changes all look good to me. I have no more nits to pick. :)
-Peff