Re: [PATCH 9/9] fetch-pack: drop custom loose object cache

From: Jeff King <peff@peff.net>
Date: Nov 12, 2018, 20:07 UTC
Message-ID: <20181112200735.GA7598@sigill.intra.peff.net>
In-Reply-To: <87efbq2isk.fsf@evledraar.gmail.com>

On Mon, Nov 12, 2018 at 08:32:43PM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 16 quoted lines

> >>  	for (ref = *refs; ref; ref = ref->next) {
> >>  		struct object *o;
> >> -		unsigned int flags = OBJECT_INFO_QUICK;
> >>
> >> -		if (use_oidset &&
> >> -		    !oidset_contains(&loose_oid_set, &ref->old_oid)) {
> >> -			/*
> >> -			 * I know this does not exist in the loose form,
> >> -			 * so check if it exists in a non-loose form.
> >> -			 */
> >> -			flags |= OBJECT_INFO_IGNORE_LOOSE;
> >
> > This removes the only user of OBJECT_INFO_IGNORE_LOOSE.  #leftoverbits
> 
> With this series applied there's still a use of it left in
> oid_object_info_extended()

That's just the code that does something with the flag. No callers pass it in anymore, so we could drop the flag _and_ that code.

-Peff