Re: [PATCH v3 0/8] fixes for unqualified <dst> push
- From
Jeff King <peff@peff.net>
- Date
- Nov 2, 2018, 06:52 UTC
- Message-ID
- <20181102065218.GK31216@sigill.intra.peff.net>
- In-Reply-To
- <20181026230741.23321-1-avarab@gmail.com>
On Fri, Oct 26, 2018 at 11:07:33PM +0000, Ævar Arnfjörð Bjarmason wrote:
Show 5 quoted lines
> After sending out v2 I noticed I didn't update the examples in a > couple of the commit messages, and figured I'd finish this up by > adding a patch to document how this works in the "git-push" > manpage. This behavior has never been properly documented. range-diff > with v2:
I read over these patches and the comments from Junio. Overall, I like the direction of the first half 5, and tend to agree with the review that the "refs/remotes" thing is going too far.
I didn't dig down into reviewing each line, since it looked like Junio already did, and there's probably a re-roll coming.
-Peff