Re: [PATCH 1/2] i18n: remote.c: mark error(...) messages for translation

From: Jeff King <peff@peff.net>
Date: Oct 10, 2018, 20:55 UTC
Message-ID: <20181010205542.GC12949@sigill.intra.peff.net>
In-Reply-To: <20181010104145.25610-2-avarab@gmail.com>

On Wed, Oct 10, 2018 at 10:41:44AM +0000, Ævar Arnfjörð Bjarmason wrote:

Show 7 quoted lines

> Mark up the error(...) messages in remote.c for translation. The likes
> of "unable to push to unqualified destination" are relatively big
> parts of the UI, i.e. error messages shown when "git push" fails.
> 
> I don't think any of these are plumbing, an the entire test suite
> passes when running the tests with GIT_GETTEXT_POISON=1 (after
> building with GETTEXT_POISON).

So obviously the second patch is much more interesting, and I focused most of my comments there. ;)

But this one seems like an obvious improvement.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.