git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] gpg-interface.c: use flags to determine key/signer info presence

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Oct 23, 2018, 22:56 UTC
Message-ID
<20181023225605.GB6119@genre.crustytoothpaste.net>
In-Reply-To
<20181022163821.23523-1-mgorny@gentoo.org>
On Mon, Oct 22, 2018 at 06:38:19PM +0200, Michał Górny wrote:
> Replace the logic used to determine whether key and signer information
> is present to use explicit flags in sigcheck_gpg_status[] array.  This
> is more future-proof, since it makes it possible to add additional
> statuses without having to explicitly update the conditions.

This series looks good to me. I was going to ask after patch 2 whether you were printing the subkey or primary key fingerprint, and then you answered my question in patch 3. Thanks for including both.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Previous: Michał GórnyNext: Junio C Hamano
Message 4 of 5 in “gpg-interface.c: use flags to determine key/signer info presence”
  1. 1/3 gpg-interface.c: use flags to determine key/signer info presenceMichał Górny, Oct 22, 2018
  2. 2/3 gpg-interface.c: Support getting key fingerprint via %GF formatMichał Górny, Oct 22, 2018
  3. 3/3 gpg-interface.c: Obtain primary key fingerprint as wellMichał Górny, Oct 22, 2018
  4. brian m. carlsonOct 23, 2018
  5. Junio C HamanoOct 24, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.