Re: Old submodules broken in 2.19rc1 and 2.19rc2

From: Jeff King <peff@peff.net>
Date: Sep 7, 2018, 15:03 UTC
Message-ID: <20180907150327.GB26719@sigill.intra.peff.net>
In-Reply-To: <2659750.rG6xLiZASK@twilight>

On Fri, Sep 07, 2018 at 11:52:58AM +0200, Allan Sandfeld Jensen wrote:

> Submodules checked out with older versions of git not longer works in the 
> latest 2.19 releases. A "git submodule update --recursive" command wil fail 
> for each submodule with a line saying "fatal: could not open 
> '<submodule>/.git' for writing> Is a directory.

I couldn't reproduce after cloning with v1.6.6.3 (which creates ".git" as a directory in the tree). Is it possible for you to bisect (or perhaps share with us the broken example)?

> I checked the release notes so far, and they do not say the old submodules 
> from git 2.16- were no longer supported, so I assume it is a bug?

I don't think it was intentional. +cc Stefan for submodule expertise.

-Peff