Re: Old submodules broken in 2.19rc1 and 2.19rc2

From: Allan Sandfeld Jensen <allan.jensen@qt.io>
Date: Sep 7, 2018, 15:18 UTC
Message-ID: <1591523.hyI6sBWrkQ@twilight>
In-Reply-To: <20180907150327.GB26719@sigill.intra.peff.net>

On Freitag, 7. September 2018 17:03:27 CEST Jeff King wrote:

Show 11 quoted lines

> On Fri, Sep 07, 2018 at 11:52:58AM +0200, Allan Sandfeld Jensen wrote:
> > Submodules checked out with older versions of git not longer works in the
> > latest 2.19 releases. A "git submodule update --recursive" command wil
> > fail
> > for each submodule with a line saying "fatal: could not open
> > '<submodule>/.git' for writing> Is a directory.
> 
> I couldn't reproduce after cloning with v1.6.6.3 (which creates ".git"
> as a directory in the tree). Is it possible for you to bisect (or
> perhaps share with us the broken example)?
>

I discovered it by using Debian testing, and it is shipping the 2.17rcs for some reason. The example is just an old checkout of qt5.git with submodules, it is rather large.

I could try bisecting, but I am not sure I have the time anytime soon, I just wanted to report it to you first incase you knew of a change that suddenly assumed the new structure.

'Allan