git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] config.mak.uname: resolve FreeBSD iconv-related compilation warning

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Aug 31, 2018, 17:00 UTC
Message-ID
<20180831170013.GA41433@aiede.svl.corp.google.com>
In-Reply-To
<20180831083342.34836-1-sunshine@sunshineco.com>
Eric Sunshine wrote:
Show 21 quoted lines
> From: Jonathan Nieder <jrnieder@gmail.com>
>
> OLD_ICONV has long been needed by FreeBSD so config.mak.uname defines
> it unconditionally. However, recent versions do not need it, and its
> presence results in compilation warnings. Resolve this issue by defining
> OLD_ICONV only for older FreeBSD versions.
>
> Specifically, revision r281550[1], which is part of FreeBSD 11, removed
> the need for OLD_ICONV, and r282275[2] back-ported that change to 10.2.
> Versions prior to 10.2 do need it.
>
> [1] https://github.com/freebsd/freebsd/commit/b0813ee288f64f677a2cebf7815754b027a8215b
> [2] https://github.com/freebsd/freebsd/commit/b709ec868adb5170d09bc5a66b18d0e0d5987ab6
>
> [es: commit message; tweak version check to distinguish 10.x versions]
>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
> ---
>  config.mak.uname | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)

I think it makes sense for you to take credit for this one. You noticed the original problem, tested on FreeBSD, wrote the explanation, and figured out the firstword hackery. All I did was to say "somebody should fix this" and run "git log -S" a few times. In any event,

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Previous: Eric SunshineNext: Eric Sunshine
Message 25 of 26 in “Makefile: enable DEVELOPER by default”
  1. Makefile: enable DEVELOPER by defaultStefan Beller, Aug 4, 2018
  2. Makefile: enable DEVELOPER by defaultStefan Beller, Aug 4, 2018
  3. Jonathan NiederAug 4, 2018
  4. Duy NguyenAug 4, 2018
  5. Junio C HamanoAug 4, 2018
  6. Ævar Arnfjörð BjarmasonAug 6, 2018
  7. Jeff KingAug 6, 2018
  8. Randall S. BeckerAug 6, 2018
  9. Jonathan NiederAug 6, 2018
  10. Jeff KingAug 6, 2018
  11. Ævar Arnfjörð BjarmasonAug 6, 2018
  12. Stefan BellerAug 6, 2018
  13. Randall S. BeckerAug 6, 2018
  14. Ævar Arnfjörð BjarmasonAug 6, 2018
  15. Randall S. BeckerAug 6, 2018
  16. Kaartic SivaraamSep 1, 2018
  17. Eric SunshineAug 5, 2018
  18. Jonathan NiederAug 5, 2018
  19. Eric SunshineAug 5, 2018
  20. Eric SunshineAug 5, 2018
  21. Jonathan NiederAug 5, 2018
  22. config.mak.uname: resolve FreeBSD iconv-related compilation warningEric Sunshine, Aug 31, 2018
  23. Ævar Arnfjörð BjarmasonAug 31, 2018
  24. Eric SunshineAug 31, 2018
  25. Jonathan NiederAug 31, 2018
  26. Eric SunshineAug 31, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.