git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: enable DEVELOPER by default

From
Stefan Beller <sbeller@google.com>
Date
Aug 4, 2018, 02:02 UTC
Message-ID
<20180804020255.225573-1-sbeller@google.com>
In-Reply-To
<20180804020009.224582-1-sbeller@google.com>

Reviewer bandwidth is limited, so let's have the machine of the (potentially new) contributor warn about issues with the code by default.

As setting DEVELOPER, the compiler is stricter and we may run into problems on some architectures. But packagers of said platforms are knowledgeable enough to turn off this flag. (Also they are fewer than the number of new contributors)

Signed-off-by: Stefan Beller <sbeller@google.com>
---
Resending with <git-packagers@googlegroups.com> cc'd.
 Makefile | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/Makefile b/Makefile
index 41b93689add..95aa3ff3185 100644
--- a/Makefile
+++ b/Makefile
@@ -497,6 +497,8 @@ ALL_CFLAGS = $(CPPFLAGS) $(CFLAGS)
 ALL_LDFLAGS = $(LDFLAGS)
 STRIP ?= strip
 
+DEVELOPER=1
+
 # Create as necessary, replace existing, make ranlib unneeded.
 ARFLAGS = rcs
 
-- 
2.18.0.597.ga71716f1ad-goog
Previous: Stefan BellerNext: Jonathan Nieder
Message 2 of 26 in “Makefile: enable DEVELOPER by default”
  1. Makefile: enable DEVELOPER by defaultStefan Beller, Aug 4, 2018
  2. Makefile: enable DEVELOPER by defaultStefan Beller, Aug 4, 2018
  3. Jonathan NiederAug 4, 2018
  4. Duy NguyenAug 4, 2018
  5. Junio C HamanoAug 4, 2018
  6. Ævar Arnfjörð BjarmasonAug 6, 2018
  7. Jeff KingAug 6, 2018
  8. Randall S. BeckerAug 6, 2018
  9. Jonathan NiederAug 6, 2018
  10. Jeff KingAug 6, 2018
  11. Ævar Arnfjörð BjarmasonAug 6, 2018
  12. Stefan BellerAug 6, 2018
  13. Randall S. BeckerAug 6, 2018
  14. Ævar Arnfjörð BjarmasonAug 6, 2018
  15. Randall S. BeckerAug 6, 2018
  16. Kaartic SivaraamSep 1, 2018
  17. Eric SunshineAug 5, 2018
  18. Jonathan NiederAug 5, 2018
  19. Eric SunshineAug 5, 2018
  20. Eric SunshineAug 5, 2018
  21. Jonathan NiederAug 5, 2018
  22. config.mak.uname: resolve FreeBSD iconv-related compilation warningEric Sunshine, Aug 31, 2018
  23. Ævar Arnfjörð BjarmasonAug 31, 2018
  24. Eric SunshineAug 31, 2018
  25. Jonathan NiederAug 31, 2018
  26. Eric SunshineAug 31, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.