Re: [PATCH] t5310-pack-bitmaps: fix bogus 'pack-objects to file can use bitmap' test
On Mon, Aug 27, 2018 at 07:04:52PM -0400, Jeff King wrote:
Show 20 quoted lines
> On Mon, Aug 27, 2018 at 10:22:46AM +0000, Kirill Smelkov wrote:
>
> > A minor comment from outside observer: running tests under something
> > like
> >
> > -e and -o pipefail
> >
> > would automatically catch the mistake in the first place. Maybe `-o
> > pipefail` is bashism (I had not checked), but `git grep " | " t/` shows
> > there are a lot of pipelines being used, and thus similar errors might be
> > silently resting there. Something like -o pipefail would catch all such
> > problems automatically.
>
> Yes, "pipefail" is a bash-ism that we can't rely on.
>
> I will say that I have been bitten before by "set -e -o pipefail" and
> its subtle handling of SIGPIPE. Try this:
>
> set -e -o pipefail
> yes | head
Thanks for the information. Oh well...