Re: [PATCH] t5310-pack-bitmaps: fix bogus 'pack-objects to file can use bitmap' test

From: Jeff King <peff@peff.net>
Date: Aug 27, 2018, 23:04 UTC
Message-ID: <20180827230452.GC10402@sigill.intra.peff.net>
In-Reply-To: <20180827102238.GA26738@deco.navytux.spb.ru>

On Mon, Aug 27, 2018 at 10:22:46AM +0000, Kirill Smelkov wrote:

Show 10 quoted lines

> A minor comment from outside observer: running tests under something
> like
> 
> 	-e and -o pipefail
> 
> would automatically catch the mistake in the first place. Maybe `-o
> pipefail` is bashism (I had not checked), but `git grep " | " t/` shows
> there are a lot of pipelines being used, and thus similar errors might be
> silently resting there. Something like -o pipefail would catch all such
> problems automatically.

Yes, "pipefail" is a bash-ism that we can't rely on.

I will say that I have been bitten before by "set -e -o pipefail" and its subtle handling of SIGPIPE. Try this:

  set -e -o pipefail
  yes | head

-Peff