Re: [PATCH v3 4/7] submodule--helper: add a new 'config' subcommand

From: Antonio Ospite <ao2@ao2.it>
Date: Aug 20, 2018, 16:50 UTC
Message-ID: <20180820185029.ba1f20d79db5479255f0ff68@ao2.it>
In-Reply-To: <20180814171058.GF240194@google.com>

On Tue, 14 Aug 2018 10:10:58 -0700 Brandon Williams <bmwill@google.com> wrote:

Show 14 quoted lines

> On 08/14, Antonio Ospite wrote:
> > Add a new 'config' subcommand to 'submodule--helper', this extra level
> > of indirection makes it possible to add some flexibility to how the
> > submodules configuration is handled.
> > 
> > Signed-off-by: Antonio Ospite <ao2@ao2.it>
> > ---
> >  builtin/submodule--helper.c | 14 ++++++++++++++
> 
> >  new                         |  0
> 
> Looks like you may have accidentally left in an empty file "new" it should
> probably be removed from this commit before it gets merged.
>

Yeah, I had added it to test "git cat-file -e new" for a later patch and then I must have messed up some rebase. Thanks for pointing it out.

Ciao,
   Antonio

-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?