git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/7] submodule: add a print_config_from_gitmodules() helper

From
Antonio Ospite <ao2@ao2.it>
Date
Aug 14, 2018, 11:05 UTC
Message-ID
<20180814110525.17801-2-ao2@ao2.it>
In-Reply-To
<20180814110525.17801-1-ao2@ao2.it>

Add a new print_config_from_gitmodules() helper function to print values from .gitmodules just like "git config -f .gitmodules" would.

This will be used by a new submodule--helper subcommand to be able to access the .gitmodules file in a more controlled way.

Signed-off-by: Antonio Ospite <ao2@ao2.it>
---
 submodule-config.c | 25 +++++++++++++++++++++++++
 submodule-config.h |  2 ++
 2 files changed, 27 insertions(+)
diff --git a/submodule-config.c b/submodule-config.c
index fc2c41b947..eef96c4198 100644
--- a/submodule-config.c
+++ b/submodule-config.c
@@ -682,6 +682,31 @@ void submodule_free(struct repository *r)
 		submodule_cache_clear(r->submodule_cache);
 }
 
+static int config_print_callback(const char *key_, const char *value_, void *cb_data)
+{
+	char *key = cb_data;
+
+	if (!strcmp(key, key_))
+		printf("%s\n", value_);
+
+	return 0;
+}
+
+int print_config_from_gitmodules(const char *key)
+{
+	int ret;
+	char *store_key;
+
+	ret = git_config_parse_key(key, &store_key, NULL);
+	if (ret < 0)
+		return CONFIG_INVALID_KEY;
+
+	config_from_gitmodules(config_print_callback, the_repository, store_key);
+
+	free(store_key);
+	return 0;
+}
+
 struct fetch_config {
 	int *max_children;
 	int *recurse_submodules;
diff --git a/submodule-config.h b/submodule-config.h
index dc7278eea4..ed40e9a478 100644
--- a/submodule-config.h
+++ b/submodule-config.h
@@ -56,6 +56,8 @@ void submodule_free(struct repository *r);
  */
 int check_submodule_name(const char *name);
 
+int print_config_from_gitmodules(const char *key);
+
 /*
  * Note: these helper functions exist solely to maintain backward
  * compatibility with 'fetch' and 'update_clone' storing configuration in
-- 
2.18.0
Previous: Antonio OspiteNext: Antonio Ospite
Message 16 of 20 in “Make submodules work if .gitmodules is not checked out”
  1. 0/7 Make submodules work if .gitmodules is not checked outAntonio Ospite, Aug 14, 2018
  2. 6/7 t7506: clean up .gitmodules properly before setting up new scenarioAntonio Ospite, Aug 14, 2018
  3. 5/7 submodule: use the 'submodule--helper config' commandAntonio Ospite, Aug 14, 2018
  4. Brandon WilliamsAug 14, 2018
  5. 7/7 submodule: support reading .gitmodules even when it's not checked outAntonio Ospite, Aug 14, 2018
  6. Brandon WilliamsAug 14, 2018
  7. Junio C HamanoAug 14, 2018
  8. Antonio OspiteAug 20, 2018
  9. Antonio OspiteAug 22, 2018
  10. Junio C HamanoAug 22, 2018
  11. Antonio OspiteAug 23, 2018
  12. 3/7 t7411: be nicer to future tests and really clean things upAntonio Ospite, Aug 14, 2018
  13. Brandon WilliamsAug 14, 2018
  14. Junio C HamanoAug 14, 2018
  15. Antonio OspiteAug 20, 2018
  16. 1/7 submodule: add a print_config_from_gitmodules() helperAntonio Ospite, Aug 14, 2018
  17. 2/7 submodule: factor out a config_set_in_gitmodules_file_gently functionAntonio Ospite, Aug 14, 2018
  18. 4/7 submodule--helper: add a new 'config' subcommandAntonio Ospite, Aug 14, 2018
  19. Brandon WilliamsAug 14, 2018
  20. Antonio OspiteAug 20, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.