git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv4 2/6] alloc: make allocate_alloc_state and clear_alloc_state more consistent

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Aug 15, 2018, 20:37 UTC
Message-ID
<20180815203735.GB181377@aiede.svl.corp.google.com>
In-Reply-To
<20180815175410.5726-3-newren@gmail.com>
Elijah Newren wrote:
Show 6 quoted lines
> Since both functions are using the same data type, they should either both
> refer to it as void *, or both use the real type (struct alloc_state *).
> Opt for the latter.
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Elijah Newren <newren@gmail.com>

Not worth rerolling for this, but these usually go in the opposite order to reflect the chronology:

  Signed-off-by: Elijah Newren <newren@gmail.com>
  Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
The patch still looks good to me. :)
Previous: Elijah NewrenNext: Elijah Newren
Message 6 of 14 in “[PATCHv4 0/6] Add missing includes and forward declares”
  1. Elijah NewrenAug 15, 2018
  2. 6/6 Remove forward declaration of an enumElijah Newren, Aug 15, 2018
  3. Jonathan NiederAug 15, 2018
  4. 4/6 urlmatch.h: fix include guardElijah Newren, Aug 15, 2018
  5. 2/6 alloc: make allocate_alloc_state and clear_alloc_state more consistentElijah Newren, Aug 15, 2018
  6. Jonathan NiederAug 15, 2018
  7. 5/6 compat/precompose_utf8.h: use more common include guard styleElijah Newren, Aug 15, 2018
  8. 3/6 Move definition of enum branch_track from cache.h to branch.hElijah Newren, Aug 15, 2018
  9. 1/6 Add missing includes and forward declarationsElijah Newren, Aug 15, 2018
  10. Jonathan NiederAug 15, 2018
  11. Jonathan NiederAug 15, 2018
  12. Ramsay JonesAug 16, 2018
  13. Junio C HamanoAug 16, 2018
  14. Jeff KingAug 16, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.