From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 15 Aug 2018 20:37:35 GMT
Subject: Re: [PATCHv4 2/6] alloc: make allocate_alloc_state and clear_alloc_state more consistent
Message-ID: <20180815203735.GB181377@aiede.svl.corp.google.com>
In-Reply-To: <20180815175410.5726-3-newren@gmail.com>

Elijah Newren wrote:

> Since both functions are using the same data type, they should either both
> refer to it as void *, or both use the real type (struct alloc_state *).
> Opt for the latter.
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Elijah Newren <newren@gmail.com>

Not worth rerolling for this, but these usually go in the opposite
order to reflect the chronology:

  Signed-off-by: Elijah Newren <newren@gmail.com>
  Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

The patch still looks good to me. :)