Re: [PATCH 2/3] gc: exit with status 128 on failure
- From
Jeff King <peff@peff.net>
- Date
- Jul 17, 2018, 19:59 UTC
- Message-ID
- <20180717195946.GC26218@sigill.intra.peff.net>
- In-Reply-To
- <20180717065416.GC177907@aiede.svl.corp.google.com>
On Mon, Jul 16, 2018 at 11:54:16PM -0700, Jonathan Nieder wrote:
> A value of -1 returned from cmd_gc gets propagated to exit(), > resulting in an exit status of 255. Use die instead for a clearer > error message and a controlled exit.
This feels a little funny because we know we're going to turn some of these back in the next patch. That said, I'm OK with it, since this version is already written.
-Peff