Re: [PATCH 1/3] gc: improve handling of errors reading gc.log

From: Jeff King <peff@peff.net>
Date: Jul 17, 2018, 19:58 UTC
Message-ID: <20180717195817.GB26218@sigill.intra.peff.net>
In-Reply-To: <20180717065321.GB177907@aiede.svl.corp.google.com>

On Mon, Jul 16, 2018 at 11:53:21PM -0700, Jonathan Nieder wrote:

Show 11 quoted lines

> A collection of minor error handling fixes:
> 
> - use an error message in lower case, following the usual style
> - quote filenames in error messages to make them easier to read and to
>   decrease translation load by matching other 'stat' error messages
> - check for and report errors from 'read', too
> - avoid being confused by a gc.log larger than INT_MAX bytes
> 
> Noticed by code inspection.
> 
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks, this all looks obviously good.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.