Re: [PATCH v2 7/9] gpg-interface: introduce new config to select per gpg format program

From: Jeff King <peff@peff.net>
Date: Jul 16, 2018, 21:35 UTC
Message-ID: <20180716213510.GJ25189@sigill.intra.peff.net>
In-Reply-To: <20180714181347.GE1042117@genre.crustytoothpaste.net>

On Sat, Jul 14, 2018 at 06:13:47PM +0000, brian m. carlson wrote:

Show 24 quoted lines

> On Tue, Jul 10, 2018 at 12:56:38PM -0400, Jeff King wrote:
> > On Tue, Jul 10, 2018 at 12:54:13PM -0400, Jeff King wrote:
> > 
> > > Should we allow:
> > > 
> > >   [gpg "OpenPGP"]
> > >   program = whatever
> > > 
> > > given that we allow:
> > > 
> > >   [gpg]
> > >   format = OpenPGP
> > > 
> > > ? I think just using strcasecmp() here would be sufficient. But I wonder
> > > if it is a symptom of using the wrong tool (subsections) when we don't
> > > need it.
> > 
> > I did just read the discussion in response to v1, where everybody told
> > you the opposite. ;)
> > 
> > So I guess my question/points are more for brian and Junio.
> 
> I'm okay with us forcing "openpgp".  That seems sane enough for now, and
> if people scream loudly, we can loosen it.

Well, I specifically meant "are you sure subsections like this are a good idea". But it seems like people think so?

If so, then I think the best route is just dictating that yes, gpg.format is case-sensitive because it is referencing gpg.<format>.program, which is itself case-sensitive (and "openpgp" is the right spelling).

-Peff