Re: [PATCH v2 3/9] gpg-interface: add new config to select how to sign a commit
- From
Jeff King <peff@peff.net>
- Date
- Jul 10, 2018, 15:56 UTC
- Message-ID
- <20180710155638.GC23624@sigill.intra.peff.net>
- In-Reply-To
- <911565bda250ebffc9a87203f2a5ae453f87e5da.1531208187.git.henning.schild@siemens.com>
On Tue, Jul 10, 2018 at 10:52:25AM +0200, Henning Schild wrote:
Show 9 quoted lines
> @@ -138,6 +139,12 @@ int git_gpg_config(const char *var, const char *value, void *cb)
> return 0;
> }
>
> + if (!strcmp(var, "gpg.format")) {
> + if (strcasecmp(value, "openpgp"))
> + return error("malformed value for %s: %s", var, value);
> + return git_config_string(&gpg_format, var, value);
> + }I know we discussed names and case-sensitivity a little bit off-list. FWIW, this name looks good to me.
-Peff