git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] convert log_ref_write_fd() to use strbuf

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Jul 13, 2018, 18:12 UTC
Message-ID
<20180713181228.GB968742@genre.crustytoothpaste.net>
In-Reply-To
<20180710210806.23384-1-benpeart@microsoft.com>
On Tue, Jul 10, 2018 at 09:08:22PM +0000, Ben Peart wrote:
Show 9 quoted lines
> Since we don't care about how many bytes were written, simplify the return
> value logic.
> 
> log_ref_write_fd() was written long before strbuf was fleshed out. Remove
> the old manual buffer management code and replace it with strbuf(). Also
> update copy_reflog_msg() which is called only by log_ref_write_fd() to use
> strbuf as it keeps things consistent.
> 
> Signed-off-by: Ben Peart <Ben.Peart@microsoft.com>
This looks good to me.  Thanks for the patch.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Previous: Junio C Hamano
Message 8 of 8 in “convert log_ref_write_fd() to use strbuf”
  1. convert log_ref_write_fd() to use strbufBen Peart, Jul 10, 2018
  2. Jeff KingJul 10, 2018
  3. Junio C HamanoJul 10, 2018
  4. Jeff KingJul 10, 2018
  5. Ben PeartJul 10, 2018
  6. convert log_ref_write_fd() to use strbufBen Peart, Jul 10, 2018
  7. Junio C HamanoJul 10, 2018
  8. brian m. carlsonJul 13, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.