From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Fri, 13 Jul 2018 18:12:28 GMT
Subject: Re: [PATCH v2] convert log_ref_write_fd() to use strbuf
Message-ID: <20180713181228.GB968742@genre.crustytoothpaste.net>
In-Reply-To: <20180710210806.23384-1-benpeart@microsoft.com>

On Tue, Jul 10, 2018 at 09:08:22PM +0000, Ben Peart wrote:
> Since we don't care about how many bytes were written, simplify the return
> value logic.
> 
> log_ref_write_fd() was written long before strbuf was fleshed out. Remove
> the old manual buffer management code and replace it with strbuf(). Also
> update copy_reflog_msg() which is called only by log_ref_write_fd() to use
> strbuf as it keeps things consistent.
> 
> Signed-off-by: Ben Peart <Ben.Peart@microsoft.com>

This looks good to me.  Thanks for the patch.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204