[PATCH 06/25] t5405: use test_must_fail() instead of checking exit code manually
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jul 2, 2018, 00:23 UTC
- Message-ID
- <20180702002405.3042-7-sunshine@sunshineco.com>
- In-Reply-To
- <20180702002405.3042-1-sunshine@sunshineco.com>
This test expects "git push" to fail, thus it manually inverts that local expected failure into a successful exit code for the test overall. In doing so, it intentionally breaks the &&-chain. Modernize by replacing manual exit code management with test_must_fail() and a normal &&-chain.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> --- t/t5405-send-pack-rewind.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/t/t5405-send-pack-rewind.sh b/t/t5405-send-pack-rewind.sh index 4bda18a662..235fb7686a 100755 --- a/t/t5405-send-pack-rewind.sh +++ b/t/t5405-send-pack-rewind.sh @@ -25,8 +25,7 @@ test_expect_success 'non forced push should die not segfault' ' ( cd another && - git push .. master:master - test $? = 1 + test_must_fail git push .. master:master ) '
-- 2.18.0.203.gfac676dfb9