Re: [PATCH v2 1/2] remote-curl: accept all encodings supported by curl
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- May 23, 2018, 02:17 UTC
- Message-ID
- <20180523021727.GJ652292@genre.crustytoothpaste.net>
- In-Reply-To
- <xmqqwovvw4fl.fsf@gitster-ct.c.googlers.com>
On Wed, May 23, 2018 at 10:23:26AM +0900, Junio C Hamano wrote:
> Similarly, how much control do we have to ensure that the test HTTPD > server (1) supports gzip and (2) does not support encoding algos > with confusing names e.g. "funnygzipalgo" that may accidentally > match that pattern?
I feel it's quite likely indeed that pretty much any Apache instance is going to have the gzip encoding. Every distributor I know supports it.
As for whether there are confusing alternate algorithms, I think it's best to just look at the IANA registration[0] to see what people are using. Potential matches include gzip, x-gzip (a deprecated alias that versions of Apache we can use are not likely to support), and pack200-gzip (a format for Java archives, which we hope the remote side will not be sending).
Overall, I think this is not likely to be a problem, but if necessary in the future, we can add a prerequisite that looks in the module directory for the appropriate module. We haven't seen an issue with it yet, though, TTBOMK.
[0] https://www.iana.org/assignments/http-parameters/http-parameters.xml#content-coding
-- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204