git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] remote-curl: accept compressed responses with protocol v2

From
Jonathan Nieder <jrnieder@gmail.com>
Date
May 22, 2018, 18:55 UTC
Message-ID
<20180522185524.GM10623@aiede.svl.corp.google.com>
In-Reply-To
<20180522184204.47332-2-bmwill@google.com>
Brandon Williams wrote:
Show 8 quoted lines
> Configure curl to accept compressed responses when using protocol v2 by
> setting `CURLOPT_ENCODING` to "", which indicates that curl should send
> an "Accept-Encoding" header with all supported compression encodings.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
>  remote-curl.c | 1 +
>  1 file changed, 1 insertion(+)
Yay!
Show 12 quoted lines
> diff --git a/remote-curl.c b/remote-curl.c
> index 565bba104..99b0bedc6 100644
> --- a/remote-curl.c
> +++ b/remote-curl.c
> @@ -1259,6 +1259,7 @@ static int proxy_request(struct proxy_state *p)
>  
>  	slot = get_active_slot();
>  
> +	curl_easy_setopt(slot->curl, CURLOPT_ENCODING, "");
>  	curl_easy_setopt(slot->curl, CURLOPT_NOBODY, 0);
>  	curl_easy_setopt(slot->curl, CURLOPT_POST, 1);
>  	curl_easy_setopt(slot->curl, CURLOPT_URL, p->service_url);
Can this get a test?

I'm particularly interested in it since it's easy to accidentally apply this patch to the wrong duplicated place (luckily 'p' is a different variable name than 'rpc' but it's an easy mistake to make if applying the patch manually).

With or without such a test,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Previous: Brandon WilliamsNext: Jonathan Nieder
Message 11 of 15 in “remote-curl: accept all encoding supported by curl”
  1. 1/2 remote-curl: accept all encoding supported by curlBrandon Williams, May 21, 2018
  2. 2/2 remote-curl: accept compressed responses with protocol v2Brandon Williams, May 21, 2018
  3. Jonathan NiederMay 22, 2018
  4. anton.golubev@gmail.comMay 26, 2018
  5. Stefan BellerMay 22, 2018
  6. Jonathan NiederMay 22, 2018
  7. Daniel StenbergMay 22, 2018
  8. Brandon WilliamsMay 22, 2018
  9. 1/2 remote-curl: accept all encodings supported by curlBrandon Williams, May 22, 2018
  10. 2/2 remote-curl: accept compressed responses with protocol v2Brandon Williams, May 22, 2018
  11. Jonathan NiederMay 22, 2018
  12. Jonathan NiederMay 22, 2018
  13. Junio C HamanoMay 23, 2018
  14. brian m. carlsonMay 23, 2018
  15. Daniel StenbergMay 23, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.