Re: [PATCH v2 2/2] remote-curl: accept compressed responses with protocol v2
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- May 22, 2018, 18:55 UTC
- Message-ID
- <20180522185524.GM10623@aiede.svl.corp.google.com>
- In-Reply-To
- <20180522184204.47332-2-bmwill@google.com>
Brandon Williams wrote:
Show 8 quoted lines
> Configure curl to accept compressed responses when using protocol v2 by > setting `CURLOPT_ENCODING` to "", which indicates that curl should send > an "Accept-Encoding" header with all supported compression encodings. > > Signed-off-by: Brandon Williams <bmwill@google.com> > --- > remote-curl.c | 1 + > 1 file changed, 1 insertion(+)
Yay!
Show 12 quoted lines
> diff --git a/remote-curl.c b/remote-curl.c > index 565bba104..99b0bedc6 100644 > --- a/remote-curl.c > +++ b/remote-curl.c > @@ -1259,6 +1259,7 @@ static int proxy_request(struct proxy_state *p) > > slot = get_active_slot(); > > + curl_easy_setopt(slot->curl, CURLOPT_ENCODING, ""); > curl_easy_setopt(slot->curl, CURLOPT_NOBODY, 0); > curl_easy_setopt(slot->curl, CURLOPT_POST, 1); > curl_easy_setopt(slot->curl, CURLOPT_URL, p->service_url);
Can this get a test?
I'm particularly interested in it since it's easy to accidentally apply this patch to the wrong duplicated place (luckily 'p' is a different variable name than 'rpc' but it's an easy mistake to make if applying the patch manually).
With or without such a test, Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>