Re: [PATCH v14 4/4] ls-remote: create '--sort' option

From: Jeff King <peff@peff.net>
Date: May 12, 2018, 09:55 UTC
Message-ID: <20180512095523.GA2234@sigill.intra.peff.net>
In-Reply-To: <b5555929-9f7c-1c4a-78e8-708ebdaaa9d2@web.de>

On Sat, May 12, 2018 at 10:45:23AM +0200, René Scharfe wrote:

Show 7 quoted lines

> Why is fetch called outside of the test?  Its output is shown among the
> test messages, where it doesn't belong:
> 
>     ok 23 - overrides work between mixed transfer/upload-pack hideRefs
>     From /home/lsr/src/git/t/trash directory.t5512-ls-remote/
>      * [new branch]      master     -> origin/master
>     ok 24 - ls-remote --symref

Heh, I just noticed this yesterday, too, but ran out of time before writing up the patch.

Show 6 quoted lines

> -- >8 --
> Subject: [PATCH] t5512: run git fetch inside test
> 
> Do the preparatory fetch inside the test of ls-remote --symref to avoid
> cluttering the test output and to be able to catch unexpected fetch
> failures.

Yep, this looks obviously correct.

-Peff