Re: [PATCH v3 1/1] perl: fix installing modules from contrib

From: Christian Hesse <mail@eworm.de>
Date: Apr 19, 2018, 21:44 UTC
Message-ID: <20180419234420.0dd66dce@leda>
In-Reply-To: <xmqq36zsgpfb.fsf@gitster-ct.c.googlers.com>

Junio C Hamano <gitster@pobox.com> on Thu, 2018/04/19 06:44:

Show 18 quoted lines

> Christian Hesse <mail@eworm.de> writes:
> 
> > Commit 20d2a30f (Makefile: replace perl/Makefile.PL with simple make
> > rules) removed a target that allowed Makefiles from contrib/ to get the
> > correct install path. This introduces a new target for main Makefile and
> > fixes installation for Mediawiki module.
> >
> > v2: Pass prefix as that can have influence as well, add single quotes
> >     for _SQ variant.
> > v3: Rename target, add to .PHONY.
> >
> > Signed-off-by: Christian Hesse <mail@eworm.de>
> > ---  
> 
> Thanks for rerolling.  I should have made it a bit more clear that
> the say-* thing was merely a personal preference "I would be writing
> it that way if I were doing it", not a "You should write it this way
> when working on this project".

Well, it's you who maintains the code. So I am fine with whatever you prefer. ;)

Show 6 quoted lines

> I think .PHONY is still a good idea
> to have, even for only its documentation value (it is unlikely that
> anybody would create a file "perllibdir").
> 
> Let me queue this on top of the v2 queued in 'next' as an
> incremental update.

Thanks a lot!

-- 
Best regards,
Chris